Ely 2534 OIDC logout support #2245
Conversation
…ck-channel logout
…an active session
…ing doesn't rely on an active session and ensure the session will get invalidated appropriately upon subsequent requests
…validation check to before the authenticator#authenticate call and update the check to not remove the session from the map to ensure that the user gets logged out from any other apps too
… the sessionsMarkedForInvalidation map
rsearls
force-pushed
the
ELY-2534-OIDC-logout-Farah-RLS-CHANGES-V2
branch
from
aef15f7 to
ebdeafe
Compare
|
@rsearls We discussed this a bit before but just wanted to add a comment here so we don't forget. The last commit in this PR is currently a bit hard to review because it contains a few changes that I had made in separate commits along with subsequent changes you made altogether in one commit. To make it a bit easier to review and understand the changes that were made, I have created a branch here that preserves the original commits we had and incorporates the changes from your branch: https://github.com/fjuma/wildfly-elytron/tree/updated-oidc-logout I have verified that the Elytron testsuite passes with this branch. I have submitted a PR against your branch (rsearls#2) so you could just click merge to get these changes included here or alternatively, you could check out my branch and then create a new PR based off that: https://github.com/fjuma/wildfly-elytron/tree/updated-oidc-logout Let me know if you have any questions about this. Thanks! |
Updated this branch to preserve some individual commits for better readability
https://issues.redhat.com/browse/ELY-2534